Rename SegString.hash() to SegString.siphash()
#1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hash()` is currently a special method in Chapel and we recently added some extra checking upstream that disallows using the name without the `override` keyword. We haven't settled on the name `hash()` yet and are considering special methods with names more unique as to not interfere with user names, but until that's settled I think it's easiest to just give the segmented string hash a different name to stay compatible. Resolves 1555
joshmarshall1
approved these changes
Jul 6, 2022
jeichert60
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hash()is currently a special method in Chapel and we recently addedsome extra checking upstream that disallows using the name without the
overridekeyword. We haven't settled on the namehash()yet and areconsidering special methods with names more unique as to not interfere
with user names, but until that's settled I think it's easiest to just
give the segmented string hash a different name to stay compatible.
Resolves #1555