Closes #1520: Always recompile Arrow when running make or make check-arrow #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes it so that the Arrow C++ code will always recompile on a `make` or `make check-arrow`. When upgrading Arrow versions, if the C++ code is not recompiled, you could end up having problems with the version that the C++ code was compiled with and the version that the Chapel code is trying to link with, which will cause problems. Also, this PR adds removal of `ArrowFunctions.o` to `make clean`.
stress-tess
changed the title
stress-tess
requested review from
joshmarshall1,
Ethan-DeBandi99 and
stress-tess
stress-tess
approved these changes
Jun 17, 2022
mhmerrill
approved these changes
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the Arrow C++ code will always recompile
on a
makeormake check-arrow. When upgrading Arrow versions,if the C++ code is not recompiled, you could end up having problems
with the version that the C++ code was compiled with and the version
that the Chapel code is trying to link with, which will cause
problems.
Also, this PR adds removal of
ArrowFunctions.otomake clean.Closes: #1520