Closes #1514: Remove trailing comma from 1 tuples in array creation message #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In chapel-lang/chapel#19713, trailing commas were added to 1 tuples and array creation was splitting on commas, which caused a problem with the new comma. This PR removes the trailing comma in the case of a 1-tuple for array creation.
bmcdonald3
force-pushed
the
trailing-comma
branch
from
a5b0d41 to
4612f8d
Compare
stress-tess
changed the title
stress-tess
approved these changes
Jun 15, 2022
mhmerrill
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In chapel-lang/chapel#19713, trailing commas
were added to 1 tuples and array creation was splitting on commas,
which caused a problem with the new comma. This PR removes the trailing
comma in the case of a 1-tuple for array creation.
Closes #1514