Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1499 - Update Requirements for Pandas #1500

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

Ethan-DeBandi99
Copy link
Contributor

Closes #1499

  • Updates setup.py, arkouda-env-dev.yml, arkouda-env.yml, and pydoc/requirements.txt to include updated dependencies for Pandas. We updated to require pandas>=1.4.0 which required other minimum versions be updated, namely numpy>=1.18.5.
  • Adds REQUIREMENTS.md file for easy identification of requirements and information on how to install dependencies and update them when they are out of date.

…as>=1.4.0 and this required updates to other dependencies for minimum supported versions.
Copy link
Contributor

@mhmerrill mhmerrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

Copy link
Contributor

@jeichert60 jeichert60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of typos:

  • Dependencies can be install using Anaconda (Recommended) or pip.
  • Dependencies can be installed using Anaconda (Recommended) or pip.
  • Users Enviorment YAML: arkouda-env.yml
  • Developer Enviornment YAML: arkouda-env-dev.yml
    Change enviornment to environment

@jeichert60 jeichert60 self-requested a review June 13, 2022 15:57
Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just highlighting the lines from jim's review. It all looks good to me

REQUIREMENTS.md Outdated Show resolved Hide resolved
REQUIREMENTS.md Outdated Show resolved Hide resolved
@stress-tess stress-tess merged commit ed79d1a into Bears-R-Us:master Jun 13, 2022
@Ethan-DeBandi99 Ethan-DeBandi99 deleted the 1499_pandas_reqs branch June 14, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Requirements for Pandas
4 participants