Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1371 - Setting mypy back to >=0.931 #1489

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

joshmarshall1
Copy link
Contributor

This PR closes #1371

Setting the mypy version to mypy>=0.931 in the developer environment .yml file and the setup.py which were both set to mypy==0.931 in #1433 until we could debug the issues I was seeing with later versions.

Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update pydoc/requirements.txt?

Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mhmerrill mhmerrill merged commit 67444fe into Bears-R-Us:master Jun 9, 2022
jeichert60 pushed a commit to jeichert60/arkouda that referenced this pull request Jun 10, 2022
* Setting mypy back to >=0.931

* Adding mypy update to requirements.txt

Co-authored-by: joshmarshall1 <[email protected]>
jeichert60 pushed a commit to jeichert60/arkouda that referenced this pull request Jun 10, 2022
* Setting mypy back to >=0.931

* Adding mypy update to requirements.txt

Co-authored-by: joshmarshall1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mypy >= 0.931 issue
4 participants