Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1412 - Add .flake to gitignore #1413

Merged
merged 4 commits into from
May 23, 2022

Conversation

Ethan-DeBandi99
Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 commented May 19, 2022

Closes #1412

  • Adds .flake8 to .gitignore
  • Adds .DS_Store to gitignore

Copy link
Member

@stress-tess stress-tess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full disclosure, i was the one who suggested using .flake8 so this on me, but i figured out that we can instead use setup.cfg, which we are already using for versioneer. So I'm requesting that we update setup.cfg to look like this

[versioneer]
VCS = git
style = pep440
versionfile_source = arkouda/_version.py
tag_prefix =
parentdir_prefix = arkouda-

[isort]
profile = black

[flake8]
max-line-length = 88
extend-ignore = E203

We can still git ignore .flake8 in case anyone wants to override our default

@Ethan-DeBandi99
Copy link
Contributor Author

[isort]
profile = black

[flake8]
max-line-length = 88
extend-ignore = E203

@pierce314159 - setup.cfg has been updated.

@Ethan-DeBandi99
Copy link
Contributor Author

Ethan-DeBandi99 commented May 20, 2022

@pierce314159 - we may want to update max line length. At least in my editor, it is showing lines as too long that aren't showing as long at all. Based on what I am seeing I would recommend setting it at 110. Though, I would like to see if maybe my editor is just wider than others or something.

@stress-tess
Copy link
Member

@pierce314159 - we may want to update max line length. At least in my editor, it is showing lines as too long that aren't showing as long at all. Based on what I am seeing I would recommend setting it at 110. Though, I would like to see if maybe my editor is just wider than others or something.

yeah this is one of the few cases where i don't like PEP 8. I'm with you, i prefer longer lines for readability

Just so everyone is aware, black already exceeds PEP 8's recommendation of 79 characters per line with it's default of 88 characters

It appears like line length is one of the only configurable things in black with the --line-length flag. I don't know if this can be set to higher than 88 or only lower tho. But i'm down for a more sensible default as long as we're all consistent about it since we all have large monitors.... and i love my long one liners :)

@Ethan-DeBandi99
Copy link
Contributor Author

I updated the max_line_length to 105. This looks like it is a good setting. This requires black to be run as black --line-length 105 <filename>. If using black as an external tool in pycharm this can be set to run automatically.

@mhmerrill mhmerrill merged commit 214604e into Bears-R-Us:master May 23, 2022
@Ethan-DeBandi99 Ethan-DeBandi99 deleted the 1412_flake_gitignore branch May 23, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .flake to git ignore
4 participants