-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1412 - Add .flake to gitignore #1413
Closes #1412 - Add .flake to gitignore #1413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full disclosure, i was the one who suggested using .flake8
so this on me, but i figured out that we can instead use setup.cfg
, which we are already using for versioneer
. So I'm requesting that we update setup.cfg
to look like this
[versioneer]
VCS = git
style = pep440
versionfile_source = arkouda/_version.py
tag_prefix =
parentdir_prefix = arkouda-
[isort]
profile = black
[flake8]
max-line-length = 88
extend-ignore = E203
We can still git ignore .flake8
in case anyone wants to override our default
@pierce314159 - |
57a9c50
to
5ad3243
Compare
@pierce314159 - we may want to update max line length. At least in my editor, it is showing lines as too long that aren't showing as long at all. Based on what I am seeing I would recommend setting it at 110. Though, I would like to see if maybe my editor is just wider than others or something. |
yeah this is one of the few cases where i don't like PEP 8. I'm with you, i prefer longer lines for readability Just so everyone is aware, black already exceeds PEP 8's recommendation of 79 characters per line with it's default of 88 characters It appears like line length is one of the only configurable things in |
I updated the |
Closes #1412
.flake8
to.gitignore
.DS_Store
togitignore