Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1377 provide RHEL installation instructions #1378

Conversation

hokiegeek2
Copy link
Contributor

@hokiegeek2 hokiegeek2 commented May 10, 2022

Closes #1377 Add Red Hat Enterprise Linux installation instructions

Copy link
Contributor

@joshmarshall1 joshmarshall1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Instructions read clearly, no issues found

@hokiegeek2 hokiegeek2 force-pushed the 1377_provide_RHEL_installation_instructions branch from 7a7582d to 0d2c005 Compare May 11, 2022 11:53
@hokiegeek2
Copy link
Contributor Author

@Ethan-DeBandi99 @joshmarshall1 cleaned up this PR via master branch rebase/cherry pick. Josh -> thanks for reviewing/approving yesterday. Please take another look and lemme know if you are cool w/ PR update. Ethan -> please review when you get a chance. Thanks dudes!

Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. Spoke with John about updating to making a few updates to clarify that we tested with cmake==3.11.0 and higher version should be compatible.

README.md Show resolved Hide resolved
Copy link
Contributor

@Ethan-DeBandi99 Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mhmerrill mhmerrill merged commit 4c647b2 into Bears-R-Us:master May 11, 2022
@hokiegeek2 hokiegeek2 deleted the 1377_provide_RHEL_installation_instructions branch May 18, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide RHEL installation instructions
4 participants