Closes #1324 - load_all() use file_format
#1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the file_format parameter. Configured so that hdf5 continues to function the same as it did. IF parquet is set, updates the file extension to .parquet. Added testing. THis needs Bears-R-Us#1309 to be merged to be functional.
Ethan-DeBandi99
requested review from
reuster986,
stress-tess,
mhmerrill and
joshmarshall1
reuster986
requested changes
Apr 26, 2022
reuster986
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1324
ak.load()andak.load_all()to make use of thefile_formatparameter that has been added for save methhods.ak.load()andak.load_all()functionality withfile_formatparameter totests/io_test.py.The code here is configured to work around some of the inconsistencies raised in #1328. Because Parquet files always have
.parquetextension, but HDF5 has more flexibility the code is configured to add the extension for parquet and continue usingos.path.splitext()for HDF5 files.