Add sanitizer check for C++ compilation in Makefile #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcdonald3
force-pushed
the
cpp-sanitizers
branch
from
4b9ed4b to
cab8098
Compare
This PR adds a check to see if the Chapel executable was built with sanitizers and, if it is, it will also compile the Arrow C++ code with those sanitizers. This change will help with nightly sanitizer testing.
bmcdonald3
force-pushed
the
cpp-sanitizers
branch
from
cab8098 to
362866c
Compare
ronawho
approved these changes
Apr 22, 2022
|
@ronawho Were you imagining that all the dependencies would be built with sanitizers enabled? If so, I would put that as a new follow up PR. If only Arrow, I would include that in this PR I think. On the other hand, it could be good to get some runs working with this simpler form before making more code changes? |
|
Yeah, I was thinking we should build all deps with sanitizers enabled. Saving that for another PR sounds fine. |
Ethan-DeBandi99
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to see if the Chapel executable was built
with sanitizers and, if it is, it will also compile the Arrow C++
code with those sanitizers. This change will help with nightly
sanitizer testing.
Closes #1322