Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reading binary data columns in Parquet #1195

Merged
merged 1 commit into from
Mar 10, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ArrowFunctions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ int cpp_getType(const char* filename, const char* colname, char** errMsg) {
return ARROWTIMESTAMP;
else if(myType->id() == arrow::Type::BOOL)
return ARROWBOOLEAN;
else if(myType->id() == arrow::Type::STRING)
else if(myType->id() == arrow::Type::STRING ||
myType->id() == arrow::Type::BINARY)
return ARROWSTRING;
else if(myType->id() == arrow::Type::FLOAT)
return ARROWFLOAT;
Expand Down Expand Up @@ -403,6 +404,7 @@ int cpp_getDatasetNames(const char* filename, char** dsetResult, char** errMsg)
sc->field(i)->type()->id() == arrow::Type::TIMESTAMP ||
sc->field(i)->type()->id() == arrow::Type::BOOL ||
sc->field(i)->type()->id() == arrow::Type::STRING ||
sc->field(i)->type()->id() == arrow::Type::BINARY ||
sc->field(i)->type()->id() == arrow::Type::FLOAT ||
sc->field(i)->type()->id() == arrow::Type::DOUBLE) {
if(!first)
Expand Down