Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatten and unflatten runtime checks failure #3679

Closed
stress-tess opened this issue Aug 19, 2024 · 0 comments · Fixed by #3680
Closed

flatten and unflatten runtime checks failure #3679

stress-tess opened this issue Aug 19, 2024 · 0 comments · Fixed by #3680
Assignees
@stress-tess

Comments

@stress-tess
Copy link
Member

when building with with gasnet, runtime checks, and multi-dim, I was seeing some test failures with the following error

arkouda//src/AryUtil.chpl:966: error: references to remote data cannot be passed to external routines like 'c_pointer_return'

reproducer:

ARKOUDA_RUNNING_MODE=CLIENT python3 -m pytest tests/array_api/array_manipulation.py
@stress-tess stress-tess self-assigned this Aug 19, 2024
stress-tess added a commit to stress-tess/arkouda that referenced this issue Aug 19, 2024
@stress-tess
Closes Bears-R-Us#3679: Flatten and unflatten runtime checks failure
167ed17 
when building with with gasnet, runtime checks, and multi-dim, I was seeing some test failures with the following error:

```
arkouda//src/AryUtil.chpl:966: error: references to remote data cannot be passed to external routines like 'c_pointer_return'
```

This was caused by some `c_ptrTo` called on some remote values. This was definitely what was intended because we were passing the addresses to `get/put`. I looked into how this was handled in the aggregation code and found `getAddr` in `CommPrimitives`. I think this does the same thing as `c_ptrTo` but avoids the runtime check? I'm not sure but making the substitution seems to have fixed the issue
github-merge-queue bot pushed a commit that referenced this issue Aug 20, 2024
@stress-tess
Closes #3679: Flatten and unflatten runtime checks failure (#3680)
3965193 
when building with with gasnet, runtime checks, and multi-dim, I was seeing some test failures with the following error:

```
arkouda//src/AryUtil.chpl:966: error: references to remote data cannot be passed to external routines like 'c_pointer_return'
```

This was caused by some `c_ptrTo` called on some remote values. This was definitely what was intended because we were passing the addresses to `get/put`. I looked into how this was handled in the aggregation code and found `getAddr` in `CommPrimitives`. I think this does the same thing as `c_ptrTo` but avoids the runtime check? I'm not sure but making the substitution seems to have fixed the issue

Co-authored-by: Tess Hayes <[email protected]>
@stress-tess stress-tess mentioned this issue Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stress-tess stress-tess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #3679: flatten and unflatten runtime checks failure stress-tess/arkouda
1 participant
@stress-tess