-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make fails when lib and lib64 directories are both present #3475
Comments
yah so just to provide some extra context. @ajpotts was having linker issues after pulling down the latest master. I don't have the specific error on me, maybe amanda can post it. But I took a look at her We didn't know if this was the problem at the time, so we just wiped the env and rebuilt from yaml and that fixed things. We noticed afterwards that the Given all that, it seems likely that this is due to #3424. As far as I understand, before that PR it would always add the I'm not exactly sure what's the best way to go about addressing this since that PR was added to fix an issue @brandon-neth was running into. But I also don't love the idea that ppl might have their |
I think I would be in favor of just going back to the old way, I'm not sure anyone else has ever encountered the error that led to #3423 when we were in that state for a couple of years, so it seems more likely to be an issue with the specific environment this was run in, rather than an issue with the build script itself... It seems unsatisfying, but I think it is hard to argue with years of never having encountering an issue and then a change causing issues very soon after, it is likely the change that is "less correct" if that makes sense. |
yah that makes sense to me! I'm up for going back to the old logic |
If you're curious, here is the error I was seeing:
|
…nt (#3503) Co-authored-by: Amanda Potts <[email protected]>
After this PR:
#3423
make
fails if bothlib
andlib64
are present and the necessary dependencies are inlib
.@stress-tess @brandon-neth @bmcdonald3
The text was updated successfully, but these errors were encountered: