Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Msg Function Registration for Module Tracking #3425

Closed
bmcdonald3 opened this issue Jul 10, 2024 · 0 comments · Fixed by #3424
Closed

Improve Msg Function Registration for Module Tracking #3425

bmcdonald3 opened this issue Jul 10, 2024 · 0 comments · Fixed by #3424
Assignees

Comments

@bmcdonald3
Copy link
Contributor

This pull request refines the logic for registering message-related functions (Msg functions) within the context of the saveUsedModules flag.

The saveUsedModules flag tracks modules that can be selectively included or excluded during the build process. However, including functions whose corresponding modules are always included by default creates unnecessary duplication in the generated function headers.

This PR introduces an explicit check to identify Msg functions with module names containing "Msg". These functions are skipped during registration, as their corresponding modules are inherently part of the build.

This will:

  • Eliminates redundant function headers
  • Ensure saveUsedModules accurately reflects modules subject to inclusion/exclusion
  • Addresses build script errors caused by registering functions from always-included modules like GenSymIO
@bmcdonald3 bmcdonald3 self-assigned this Jul 10, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 10, 2024
…3424)

* Only register Msg functions with a module name
With the `saveUsedModules` flag, we only want to be tracking
modules that can actually be included/excluded to avoid duplicating
function headers for those functions that are always included by
default.

By explicitly checking if the module name includes "Msg", we can
skip this for cases like `GenSymIO` which are always included and
was causing build issues with the module generation script.

* Add registration without module name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant