Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code duplication in Parquet read code with templates #3360

Open
bmcdonald3 opened this issue Jun 25, 2024 · 0 comments
Open

Reduce code duplication in Parquet read code with templates #3360

bmcdonald3 opened this issue Jun 25, 2024 · 0 comments
Assignees
@bmcdonald3

Comments

@bmcdonald3
Copy link
Contributor

bmcdonald3 commented Jun 25, 2024 •
edited
Loading

The Parquet code previously had been duplicating blocks of code with only changing the types. To reduce this duplication to improve readability and maintainability, template functions are being added in place of the duplicate code.

This reduces the readColumnByName function from 198 lines to 100 lines, so about 50% reduction in function size.

Additionally, since the code is no longer duplicated, changes won't need to be put in multiple places.
@bmcdonald3 bmcdonald3 self-assigned this Jun 25, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 26, 2024
@bmcdonald3
Closes #3360: Reduce code duplication in Parquet read code with templ…
4e5d4c6 
…ates (#3361)

* Add templatized read column function

* Cleanup irregular bit width case

* Templatize float and double
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmcdonald3 bmcdonald3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmcdonald3