New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse and improve structure for random generation methods #3336

Closed

stress-tess opened this issue Jun 17, 2024 · 0 comments · Fixed by #3352

Assignees

Member

stress-tess commented Jun 17, 2024 •

edited

Loading

creating a record similar to what jeremiah suggested here to avoid having the duplicated code for single value and array versions of distribution parameters
pulling out the structure into a proc (like which takes the actual distribution method as an inline proc. This will be along the lines of what is done in SegmentedComputation.chpl
- A dry run of something similar (with an outdated stream per task structure) can be seen with exponential here

I just wanted to get this fixed as soon as possible and not complicate the review

Originally posted by @stress-tess in #3331 (comment)

The text was updated successfully, but these errors were encountered:

stress-tess self-assigned this

stress-tess mentioned this issue

Closes #3336, #3362: Reuse random number generation loop structure #3352

Merged

github-merge-queue bot pushed a commit that referenced this issue


          Closes #3336, #3362: Reuse random number generation loop structure (#…

7b51173

…3352)

* first pass

* closes #3362 fix bug in thisLocsNumChunks calculation

---------

Co-authored-by: Tess Hayes <[email protected]>

stress-tess closed this as completed in #3352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment