Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failures due to indexof1d #3229

Closed
stress-tess opened this issue May 22, 2024 · 1 comment
Closed

CI failures due to indexof1d #3229

stress-tess opened this issue May 22, 2024 · 1 comment
Assignees
@stress-tess

Comments

@stress-tess
Copy link
Member

stress-tess commented May 22, 2024 •
edited
Loading

We're seeing CI failures from the new indexof1d: https://github.com/Bears-R-Us/arkouda/actions/runs/9196080930/job/25293360608?pr=3223

=========================== short test summary info ============================
FAILED tests/setops_test.py::SetOpsTest::test_index_of - ValueError: shape mismatch [26] [20]
====== 1 failed, 638 passed, 1 skipped, 88 warnings in 559.10s (0:09:19) =======
@stress-tess stress-tess self-assigned this May 22, 2024
@stress-tess
Copy link
Member Author

The path forward if I'm unable to reproduce will likely be to revert the functionality until after the release. Then we'll add it back with a seed

stress-tess added a commit to stress-tess/arkouda that referenced this issue May 23, 2024
@stress-tess
Part of Bears-R-Us#3229: CI failures due to indexof1d
186dfde 
This PR is part of Bears-R-Us#3229. We were seeing CI failures due to `indexof1d`. I reverted back to the original implementation until I can look into this more. I added a transmute to ensure proper handling on `nan`s. I also modified the test to write out seeds to make future failures easier to reproduce
@stress-tess stress-tess mentioned this issue May 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 27, 2024
@stress-tess
Part of #3229: CI failures due to indexof1d (#3232)
e816bf5 
This PR is part of #3229. We were seeing CI failures due to `indexof1d`. I reverted back to the original implementation until I can look into this more. I added a transmute to ensure proper handling on `nan`s. I also modified the test to write out seeds to make future failures easier to reproduce

Co-authored-by: Tess Hayes <[email protected]>
@stress-tess stress-tess mentioned this issue Jun 11, 2024
Closed
stress-tess added a commit to stress-tess/arkouda that referenced this issue Jun 12, 2024
@stress-tess
Part of Bears-R-Us#3229: Re-enable find implementation of indexof1d
5d7e4d5 
This PR is part of Bears-R-Us#3229. Re-enable the `find` implementation. I modified it to have a more optimized way of finding all occurences (which will hopefully also solve the issue we were seeing in the CI). While I'm not sure if this is the best way of calculating this, it's no longer the bottleneck and it gets better performance than the current implementation.

Previously I added seeds to the `indexof1d` test, so it will be easier to reproduce any failures. I'm not closing the issue yet since there's still some code cleanup to be done, and I want to leave exisiting code to make it easier to fall back to a similar approach in the event that the `find` way still has issues.
@stress-tess stress-tess mentioned this issue Jun 12, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 12, 2024
@stress-tess
Part of #3229: Re-enable find implementation of indexof1d (#3316)
3043f38 
This PR is part of #3229. Re-enable the `find` implementation. I modified it to have a more optimized way of finding all occurences (which will hopefully also solve the issue we were seeing in the CI). While I'm not sure if this is the best way of calculating this, it's no longer the bottleneck and it gets better performance than the current implementation.

Previously I added seeds to the `indexof1d` test, so it will be easier to reproduce any failures. I'm not closing the issue yet since there's still some code cleanup to be done, and I want to leave exisiting code to make it easier to fall back to a similar approach in the event that the `find` way still has issues.

Co-authored-by: Tess Hayes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stress-tess stress-tess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stress-tess