Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add normal to random number generators #3167

Closed
Tracked by #2984
stress-tess opened this issue May 8, 2024 · 0 comments · Fixed by #3180
Closed
Tracked by #2984

Add normal to random number generators #3167

stress-tess opened this issue May 8, 2024 · 0 comments · Fixed by #3180
Assignees
@stress-tess
Labels
enhancement New feature or request
Milestone
Random module ali...

Comments

@stress-tess
Copy link
Member

stress-tess commented May 8, 2024 •
edited
Loading

Add normal to our generators, we already have a fillRandom helper in Random.chpl so this shouldn't be a big lift

Relevant numpy docs:
@stress-tess stress-tess mentioned this issue May 8, 2024
Open
11 tasks
@stress-tess stress-tess self-assigned this May 8, 2024
@stress-tess stress-tess added the enhancement New feature or request label May 8, 2024
stress-tess added a commit to stress-tess/arkouda that referenced this issue May 13, 2024
@stress-tess
Closes Bears-R-Us#3167: Add normal to random number generators
f86f5f6 
This PR (closes Bears-R-Us#3167) adds `normal` to our generators by transforming the results of standard normal. It also upddates `standard_normal` to use generators ot make sure we have the same multiple calls of the same function give different output as the other rand funcs. Adds goodness of fit testing against scipy to ensure we are actually drawing from the correct distribution
@stress-tess stress-tess mentioned this issue May 13, 2024
Merged
stress-tess added a commit to stress-tess/arkouda that referenced this issue May 20, 2024
@stress-tess
Closes Bears-R-Us#3167: Add normal to random number generators
33b0828 
This PR (closes Bears-R-Us#3167) adds `normal` to our generators by transforming the results of standard normal. It also upddates `standard_normal` to use generators ot make sure we have the same multiple calls of the same function give different output as the other rand funcs. Adds goodness of fit testing against scipy to ensure we are actually drawing from the correct distribution
stress-tess added a commit that referenced this issue May 21, 2024
@stress-tess
Closes #3167: Add normal to random number generators (#3180)
af41bb8 
* Closes #3167: Add `normal` to random number generators

This PR (closes #3167) adds `normal` to our generators by transforming the results of standard normal. It also upddates `standard_normal` to use generators ot make sure we have the same multiple calls of the same function give different output as the other rand funcs. Adds goodness of fit testing against scipy to ensure we are actually drawing from the correct distribution

* add docs for random functions and deps to yaml files

* leftover latex preventing display in usage

---------

Co-authored-by: Tess Hayes <[email protected]>
@stress-tess stress-tess added this to the Random module alignment milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stress-tess stress-tess

Labels
enhancement New feature or request
Projects
None yet
Milestone
Random module alignment
Development

Successfully merging a pull request may close this issue.

Closes #3167: Add normal to random number generators stress-tess/arkouda
1 participant
@stress-tess