Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permutation to random number generators #3071

Closed
Tracked by #3066
stress-tess opened this issue Apr 1, 2024 · 0 comments · Fixed by #3078
Closed
Tracked by #3066

Add permutation to random number generators #3071

stress-tess opened this issue Apr 1, 2024 · 0 comments · Fixed by #3078

Comments

@stress-tess
Copy link
Member

stress-tess commented Apr 1, 2024

Add permutation to our generators, we can get this easily permute method defined on chpl generators

Relevant numpy documentation:

stress-tess added a commit to stress-tess/arkouda that referenced this issue Apr 3, 2024
This PR (closes Bears-R-Us#3071) adds permutation to `rng`.

The array version of the chpl `permute` proc requires idxType must be coercible from this stream’s eltType, so instead we use the domain version of `permute` and use that to gather the permuted vals. But we're not missing out on much because the array version seems to do the same thing but without aggregation
stress-tess added a commit to stress-tess/arkouda that referenced this issue Apr 3, 2024
This PR (closes Bears-R-Us#3071) adds permutation to `rng`.

The array version of the chpl `permute` proc requires idxType must be coercible from this stream’s eltType, so instead we use the domain version of `permute` and use that to gather the permuted vals. But we're not missing out on much because the array version seems to do the same thing but without aggregation
github-merge-queue bot pushed a commit that referenced this issue Apr 5, 2024
* Closes #3071: Add permutation to rng

This PR (closes #3071) adds permutation to `rng`.

The array version of the chpl `permute` proc requires idxType must be coercible from this stream’s eltType, so instead we use the domain version of `permute` and use that to gather the permuted vals. But we're not missing out on much because the array version seems to do the same thing but without aggregation

* update in response to PR feedback and added float test

---------

Co-authored-by: Tess Hayes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant