Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert non sym entry array creations to new throwing interface #2790

Closed
bmcdonald3 opened this issue Sep 27, 2023 · 0 comments · Fixed by #2791
Closed

Convert non sym entry array creations to new throwing interface #2790

bmcdonald3 opened this issue Sep 27, 2023 · 0 comments · Fixed by #2791
Assignees
@bmcdonald3

Comments

@bmcdonald3
Copy link
Contributor

The initial work to convert array creations to the new throwing creations focused on symbol table entries, leaving out freestanding arrays created during a function. This PR converts those remaining arrays, meaning that all block distributed arrays created should be converted over to the new interface. Default rectangular arrays are not included and some of the more complex initialization expression arrays were not converted due to an internal error, but have been noted and are in progress as follow up work.
@bmcdonald3 bmcdonald3 self-assigned this Sep 27, 2023
@bmcdonald3 bmcdonald3 mentioned this issue Sep 27, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 29, 2023
@bmcdonald3
Closes #2790: Convert non sym entry array creations to new throwing i…
466f165 
…nterface (#2791)

* Finish first pass of conversion

* Add throws and fix some errors

* Building after rebase

* Switch domains to generic

* Convert some missed allocations

* Convert init expressions

* Add initExpr overloads to compat modules

* Undo atomic conversion, which didn't make sense
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmcdonald3 bmcdonald3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2790: Convert non sym entry array creations to new throwing interface bmcdonald3/arkouda
1 participant
@bmcdonald3