Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address sanitizer errors on unregister #2737

Closed
stress-tess opened this issue Aug 30, 2023 · 0 comments · Fixed by #2741
Closed

Address sanitizer errors on unregister #2737

stress-tess opened this issue Aug 30, 2023 · 0 comments · Fixed by #2741
Assignees
Labels
bug Something isn't working

Comments

@stress-tess
Copy link
Member

stress-tess commented Aug 30, 2023

When building chapel with the address sanitizer (instructions here). We see an access after free error when something gets unregistered

>>> a = ak.arange(10)
>>> a.register('pda')
array([0 1 2 3 4 5 6 7 8 9])
>>> a.unregister()

This results in a AddressSanitizer: heap-use-after-free error. This seems to be the result of removing the name from the registry table

tab.remove(are.name);

This is the error that led to the nightly failures that caused us to skip testNA in #2726. But this doesn't just apply to categorical, it happens when unregistering any object

@stress-tess stress-tess added the bug Something isn't working label Aug 30, 2023
@stress-tess stress-tess self-assigned this Aug 30, 2023
stress-tess pushed a commit to stress-tess/arkouda that referenced this issue Aug 30, 2023
This PR (fixes Bears-R-Us#2737) changes `registry.lookup` to return a shared object instead of borrowed. This make it so later references to `gre` in `unregisterMsg` don't cause us to access freed memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant