-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework arange
handling of uint
and bigint
arguments
#2603
Labels
Technical Debt
Rework code for more flexibility or readability
Comments
stress-tess
added
bug
Something isn't working
Technical Debt
Rework code for more flexibility or readability
labels
Jul 21, 2023
stress-tess
changed the title
bug in
bug in Jul 21, 2023
arange
handling of uint
arguments >2**63
arange
handling of uint
and bigint
arguments
Oh i think i'm being dumb. We def needed to rework this but |
stress-tess
changed the title
bug in
rework Jul 21, 2023
arange
handling of uint
and bigint
argumentsarange
handling of uint
and bigint
arguments
stress-tess
pushed a commit
to stress-tess/arkouda
that referenced
this issue
Jul 21, 2023
This PR (closes Bears-R-Us#2603) rework how arange handles `uint` and `bigint` arguments. This update provides the correct return for something in the `> 2**63` range such as `ak.arange(2**63, 2**63+15)`
stress-tess
pushed a commit
to stress-tess/arkouda
that referenced
this issue
Jul 21, 2023
This PR (closes Bears-R-Us#2603) rework how arange handles `uint` and `bigint` arguments. This update provides the correct return for something in the `> 2**63` range such as `ak.arange(2**63, 2**63+15)`
stress-tess
pushed a commit
to stress-tess/arkouda
that referenced
this issue
Jul 21, 2023
This PR (closes Bears-R-Us#2603) rework how arange handles `uint` and `bigint` arguments. This update provides the correct return for something in the `> 2**63` range such as `ak.arange(2**63, 2**63+15)`
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 24, 2023
This PR (closes #2603) rework how arange handles `uint` and `bigint` arguments. This update provides the correct return for something in the `> 2**63` range such as `ak.arange(2**63, 2**63+15)` Co-authored-by: Pierce Hayes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to rework
arange
, right now the chapel code assumes if the arguments aren'tbigint
that they areint
. This leads to server crash when arguments areuint
s in the2**63..2**64
rangefor example:
the server crashes with this error message
I think we can get around this by using
resolve_scalar_dtype
to determine the type of the arguments. Then we can either pass this to the chpl side and do a select or just get this info from message argsIt's worth noting this isn't terrible to workaround (we can just add the
2**63
after the fact), but this should def be handled correctlyThe text was updated successfully, but these errors were encountered: