Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compat version of c_void_ptr for new c_ptr(void) #2593

Closed
riftEmber opened this issue Jul 18, 2023 · 0 comments · Fixed by #2594
Closed

Add compat version of c_void_ptr for new c_ptr(void) #2593

riftEmber opened this issue Jul 18, 2023 · 0 comments · Fixed by #2594

Comments

@riftEmber
Copy link
Contributor

Chapel recently deprecated c_void_ptr in favor of c_ptr(void), which will be in the 1.32 release (PR chapel-lang/chapel#22637). This also included compiler changes to make c_ptr(void) possible, which would not previously compile. To avoid use of the now-deprecated c_void_ptr in versions newer than 1.31, introduce a new c_ptr_void symbol in ArkoudaCTypesCompat which is c_void_ptr for Chapel <=1.31, and c_ptr(void) for Chapel >1.31.
@riftEmber riftEmber mentioned this issue Jul 18, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 20, 2023
@riftEmber
Closes #2593: Add compat version of c_void_ptr for new c_ptr(void) (
418e75a 
#2594)

* Use c_ptr_void mapping to c_void_ptr or c_ptr(void) for compat

* Use alternative solution to allow c_void_ptr for any Chapel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #2593: Add compat version of c_void_ptr for new c_ptr(void)
1 participant
@riftEmber