-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily change test_randint_randomness
not to run
#1672
Comments
Upon thinking about this a bit more, I think we should actually not run the test for now. I did some quick back of the envelope math (which should def be double checked because i'm very bad at stats): So the probability of getting Since the overall test only fails if we have >4 failures, to calculate the odds of overall success we can sum the probabilities of passing 16, 17, 18, 19, and 20 trials (since these are all independent events) so the odds of failure is |
@pierce314159 - based on this, I am inclined to agree. We should probably pull the test for now. |
test_randint_randomness
test_randint_randomness
not to run
…t to run This PR (Closes Bears-R-Us#1672): - Changes the name of `test_randint_randomness` to `randint_randomness` which will cause the test to not run
…1673) This PR (Closes #1672): - Changes the name of `test_randint_randomness` to `randint_randomness` which will cause the test to not run Co-authored-by: Pierce Hayes <[email protected]>
test_randint_randomness
has been failing in CI runs a bit too frequently. We should lower the threshold for now and decide how we want to proceed (either relying solely onrandtest
after #1665 or if we are okay with the lower confidence test)The text was updated successfully, but these errors were encountered: