Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

df.save() fails with SegArray columns #1456

Closed
reuster986 opened this issue May 31, 2022 · 0 comments · Fixed by #1467
Closed

df.save() fails with SegArray columns #1456

reuster986 opened this issue May 31, 2022 · 0 comments · Fixed by #1467
Assignees
@Ethan-DeBandi99
Labels
bug Something isn't working In Progress Work on ticket is in progress / ticket is actively being worked

Comments

@reuster986
Copy link
Collaborator

When saving a DataFrame that has SegArray columns, arkouda raises a TypeError, seemingly because SegArray.save() does not comprehend the file_format argument.

Reproducer:

>>> df = ak.DataFrame({'a': ak.arange(10), 'b': ak.SegArray(ak.arange(10), ak.arange(10))})
>>> df.save('./test_path')
TypeError: save() got an unexpected keyword argument 'file_format'
@Ethan-DeBandi99 Ethan-DeBandi99 self-assigned this Jun 1, 2022
@Ethan-DeBandi99 Ethan-DeBandi99 added bug Something isn't working In Progress Work on ticket is in progress / ticket is actively being worked labels Jun 1, 2022
@Ethan-DeBandi99 Ethan-DeBandi99 mentioned this issue Jun 1, 2022
Merged
mhmerrill pushed a commit that referenced this issue Jun 6, 2022
@Ethan-DeBandi99
Closes #1456 - df.save() with SegArray Column (#1467)
8db89d0 
* Updating dataframe to only use save and load functions. Updating segarray save to use file_format. Updating test.

* Updated load to properly format the segarray within dataframes. Added test to ensure functional.

* Updating to use save/load in place of save_table/load_table

* removing old commented out code.

* Updating with black and isort to avoid merge conflicts.

* Rebase cleanup

* Removing unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ethan-DeBandi99 Ethan-DeBandi99

Labels
bug Something isn't working In Progress Work on ticket is in progress / ticket is actively being worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #1456 - df.save() with SegArray Column Ethan-DeBandi99/arkouda
2 participants
@Ethan-DeBandi99 @reuster986