Fixes #3821: Bug in stridable indexing of Strings in multilocale (#3830)

* Fixes #3821: Bug in stridable indexing of Strings in multilocale This PR fixes #3821 which gave incorrect results for stridable index into segstrngs on multilocale * remove test skip --------- Co-authored-by: Tess Hayes <[email protected]> Co-authored-by: ajpotts <[email protected]>
Bears-R-Us · Oct 10, 2024 · 842b51e · 842b51e
1 parent aaebded
commit 842b51e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/src/SegmentedString.chpl b/src/SegmentedString.chpl
@@ -207,9 +207,7 @@ module SegmentedString {
 
     proc this(const slice: range(strides=strideKind.any)) throws {
       var aa = makeDistArray(slice.size, int);
-      forall (elt,j) in zip(aa, slice) with (var agg = newSrcAggregator(int)) {
-        agg.copy(elt,j);
-      }
+      aa = slice;
       return this[aa];
     }
 

diff --git a/tests/numpy/manipulation_functions_test.py b/tests/numpy/manipulation_functions_test.py
@@ -40,8 +40,6 @@ def test_flip_multi_dim_bool(self, size):
         f2 = ak.broadcast(segments=segs, values=vals2, permutation=perm).reshape(shape)
         assert_equal(f, f2)
 
-    #   Currently there is a bug in the reverse indexing of Strings (#3821) that causes this test to fail.
-    @pytest.mark.skip("Skip until bug fix Ticket #3821 is completed.")
     @pytest.mark.parametrize("size", pytest.prob_size)
     def test_flip_string(self, size):
         s = ak.random_strings_uniform(1, 2, size, seed=seed)