Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two major changes in this pull request:
arachne.py
. This file was split up into two for now withgraphclasses.py
that contains the definitions forGraph
,DiGraph
, andPropGraph
. All methods using graphs and the matrix market file reading method were placed intomethods.py
. This will facilitate searching for methods to update and make things cleaner.forall
loop to afor
loop within aforall
loop. For triangle counting in a full graph, both nestedforall
loops will always iterate on the same locales with the same threads leading to thread contention. This improved performance forminimum_search_triangle_count_kernel
. However, forminimum_search_triangle_count_per_vertex
there is a chance a nestedforall
loop could be kept since the neighbors of a vertex could be on remote locales, however in a shared-memory sense, removing the nestedforall
loop made more sense.