Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ppy.osu.Game from 2023.1026.0 to 2023.1223.0 #352

Merged
merged 3 commits into from
Dec 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Rush/Judgements/RushJudgementResult.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ public RushJudgementResult(RushHitObject hitObject, RushJudgement judgement)
{
}

public override string ToString() => $"{Type} (Score:{Judgement.NumericResultFor(this)} HP:{Judgement.HealthPointIncreaseFor(this)} {Judgement})";
public override string ToString() => $"{Type} (HP:{Judgement.HealthPointIncreaseFor(this)} {Judgement})";
}
}
23 changes: 22 additions & 1 deletion osu.Game.Rulesets.Rush/UI/Fever/FeverProcessor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,28 @@ private static float feverIncreaseFor(JudgementResult result)
if (result.Judgement is RushIgnoreJudgement || result.Judgement is RushFeverJudgement)
return 0;

return (float)result.Judgement.NumericResultFor(result) / result.Judgement.MaxNumericResult / perfect_hits_to_fill;
return (float)NumericResultFor(result.Type) / NumericResultFor(HitResult.Great) / perfect_hits_to_fill;
}

public static int NumericResultFor(HitResult result)
{
switch (result)
{
default:
return 0;

case HitResult.Good:
return 200;

case HitResult.Great:
return 300;

case HitResult.SmallBonus:
return 10;

case HitResult.LargeBonus:
return 50;
}
}
}
}
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Rush/osu.Game.Rulesets.Rush.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
</EmbeddedResource>
</ItemGroup>
<ItemGroup>
<PackageReference Include="ppy.osu.Game" Version="2023.1026.0" />
<PackageReference Include="ppy.osu.Game" Version="2023.1223.0" />
</ItemGroup>
</Project>
Loading