Add replay recording support #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seeing as rush doesn't record any positional inputs, it would be possible to repurpose one of those values as a bitflag of some sort, similar to mania's implementation. This will make sure the playback matches the actions performed during recording. |
|
Yeah now I realize what you meant back then, will see. |
swoolcock
requested changes
Apr 10, 2021
To indicate that the numbers assigned to each action must never change, to avoid breaking old rush! replay frames, or configuration, etc..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently has to convert from and to legacy replay frames due to no modern replay encoding support osu!lazer-side yet, which limits tertiary and quaternary actions from being saved as-is in replays, but looks to be working as expected to for now.