Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

#47 frontend-dev runs yarn install on docker-compose up #57

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

martinjrobins
Copy link
Collaborator

Fixes #47

@martinjrobins martinjrobins requested a review from mjaquiery March 1, 2023 13:48
Copy link
Collaborator

@mjaquiery mjaquiery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- do you know if it'll also manage to yarn install when running the production deployment? Can you test that if necessary and then merge when you're happy, please?

@martinjrobins
Copy link
Collaborator Author

in a production env node_modules is in /usr/share/nginx/html so this won't be a problem. In fact I'm not sure why this mapping is in the prod docker-compose file:

    volumes:
     - ./frontend:/app

Should this be only in the dev docker-compose?

@martinjrobins
Copy link
Collaborator Author

I tried prod deploy and seems to work ok, merging....

@martinjrobins martinjrobins merged commit 30a0cee into v2.0.0 Mar 1, 2023
@martinjrobins martinjrobins deleted the i47-node-modules branch March 1, 2023 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants