This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Matlab #30
Merged
Matlab #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2022 10:51
martinjrobins
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
thanks @mjaquiery. This looks great. The matlab code is nice and simple, which is a plus! I was thinking of trying out https://github.com/Open-MBEE/swagger-codegen-matlab-client to automatically generate the matlab client from the openapi spec, but this can be left until later (as you see in #26 , this can create problems....)
|
@martinjrobins I didn't find the swagger MATLAB thing (although I did find that OpenAPI Generator doesn't support MATLAB). If the current code won't suffice we can certainly try upgrading to a full API client, especially once I fix the issue behind #26. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MATLAB code is not completely equal to Python code (it doesn't do column selection but does allow for extending to multiple datasets). That can be changed if we like, I suppose!