-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for explainable
for model with continuous variables
#565
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment for requested changes.
* edit intro * progress * remove plate and more edits
… explainable-continuous-doc
Possibly this is because |
Thanks @SamWitty for such detailed feedback! I have reacted to all the suggestions, here is a rundown of the changes.
Modified the discussion in the outline to already bring this up.
Added a conclusions section. Brought up also policy-making a bit, but am not sure what other thoughts at that level of abstraction are worth being brought up.
Added an assumptions subsection.
Added a comment about this, Interestingly, this is a solution that you yourself suggested. :)
Yup, thanks!
Done!
Added an explanation of the inference strategy.
Added an explanation.
Added reference to a particular chapter in Halpern's book - unless you had something else in mind?
So I think those one-number summaries are important, but also that the user needs to understand what they are and how to go beyond them. Tried to explain this in more detail in the current version. “Counterfactual - necessity world” figure (and all following similar plots) requests:
Fixed.
Sure, fixed.
I think the terminology is quite natural, but I can see how it wasn't introduced. So I added an explanation of these notions now. As for explaining in terms of notation, this is done in the current version of the categorical variables tutorial so I refer the reader to it. At this point I think doing something analogous here would overburden the reader as it wouldn't be too straightforward: the notation is for particular interventional settings and values under settings, whereas possible worlds cut through those.
Revised the heatmap and added more extensive explanation thereof. |
This pull request adds a tutorial for the module
explainable
in the context of a model with continuous variables and dynamical systems.