Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tutorial on the probabilities of necessity and sufficiency #540

Merged
merged 53 commits into from
May 31, 2024
Merged

add tutorial on the probabilities of necessity and sufficiency #540

merged 53 commits into from
May 31, 2024

Conversation

rfl-urbaniak
Copy link
Collaborator

In light of expanding SearchFor... to allow for sufficiency computations, we add a tutorial that accounts for this update, and eliminates reference to auxiliary nodes, updating and simplifying the explanation.

@rfl-urbaniak
rename consequent_differs to consequent_neq
56a5bc9
@rfl-urbaniak
add consequent_eq
fde5763
@rfl-urbaniak
lint
ecb8bee
@rfl-urbaniak
added sufficiency_intervention
1187f2d
@rfl-urbaniak
generalized hints for sufficiency_intervention
12417de
@rfl-urbaniak
add event_dim to indices_of within sufficiency intervention
c1524a4
@rfl-urbaniak
added antecedents in sufficiency_intervention
2e1d2bf
@rfl-urbaniak
test sufficiency_intervention with split
38e8b45
@rfl-urbaniak
format, lint
f420cc4
@rfl-urbaniak
expanded antecedents in scribbles.ipynb
bbcfd41
@rfl-urbaniak
fixed sufficiency_intervention and test thereof
4258904
@rfl-urbaniak
consequents to consequents_nec in scribbles
cccce74
@rfl-urbaniak
working eq and neq
9951733
@rfl-urbaniak
fixed the event dim bug
1af2984
@rfl-urbaniak
added consequent_eq_neq
4a5d850
@rfl-urbaniak
format lint
a7cf737
@rfl-urbaniak
added naming to do within components WIP
4b6cd88
@rfl-urbaniak
debugged consequent_eq_neq to handle upstream interventions
552e7e4
@rfl-urbaniak
generalizing across event shapes WIP
1695b82
@rfl-urbaniak
debugging events WIP
a82a890
@rfl-urbaniak
generalizing to SearchForNS WIP
08b789c
@rfl-urbaniak
working forest fire example
eb3f757
@rfl-urbaniak
extract distros from the ff example
9695469
@rfl-urbaniak
state before reverting
dd5ea44
@rfl-urbaniak
reverted on sufficiency_intervention
c2089d1
@rfl-urbaniak
Merge branch 'master' of https://github.com/BasisResearch/chirho into…
4db07a3 
… ru-sufficiency
@rfl-urbaniak
reinstate counterfactual
a1e35fb
@rfl-urbaniak
reverted on SplitSubsets
7ed7d19
@rfl-urbaniak
simplified test consequent eq_neq, moving on
5b55a13
@rfl-urbaniak
SearchForNS into explainable
988f797
eb8680
eb8680 reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@eb8680 eb8680 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfl-urbaniak can you push the code changes to your upstream PR #536 ?

@rfl-urbaniak
Copy link
Collaborator Author

@eb8680 pushed

Base automatically changed from ru-sufficiency to master May 8, 2024 20:41
@eb8680 eb8680 added examples module:explainable status:awaiting review Awaiting response from reviewer status:WIP Work-in-progress not yet ready for review and removed status:WIP Work-in-progress not yet ready for review status:awaiting review Awaiting response from reviewer labels May 31, 2024
@eb8680 eb8680 merged commit 916652d into master May 31, 2024
6 of 7 checks passed
@eb8680 eb8680 deleted the ru_pns-tutorial branch May 31, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eb8680 eb8680 eb8680 left review comments

Assignees

@rfl-urbaniak rfl-urbaniak

Labels
examples module:explainable status:awaiting review Awaiting response from reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfl-urbaniak @eb8680