Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header formatting in dynamical_intro #436

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

eb8680
Copy link
Contributor

@eb8680 eb8680 commented Dec 7, 2023

One of the outline entries in dynamical_intro.ipynb is rendered incorrectly by Sphinx.

@eb8680 eb8680 added documentation Improvements or additions to documentation status:awaiting review Awaiting response from reviewer labels Dec 7, 2023
@eb8680 eb8680 requested a review from SamWitty December 7, 2023 15:24
@SamWitty
Copy link
Collaborator

SamWitty commented Dec 7, 2023

I also just noticed that the lists (e.g. S(t)) are also being renderred incorrectly.
Screenshot 2023-12-07 at 10 32 10 AM

@SamWitty
Copy link
Collaborator

SamWitty commented Dec 7, 2023

I took the liberty of just pushing that fix, because it was small and obvious what the original intent was. In the future I'll just make a small PR.

@eb8680 eb8680 merged commit 7cf295f into master Dec 7, 2023
7 checks passed
@eb8680 eb8680 deleted the eb-dynamical-fix-intro-header branch December 7, 2023 16:01
SamWitty added a commit that referenced this pull request Dec 8, 2023
* Revise basic SIR tutorial (#377)

* changes dynamical systems intro to be more short-term focussed

* suppress warnings

* remove counterfactual demo

* remove unused imports and reorder imports

* add failing LogTrajectory test

* revise tests to exercise start and end time collisions

* removed unnecessary imports from test

* much simpler implementation

* lint and comment

* added some functional indirection to appease linter

* lint

* type refinement

* nit about arg unpacking order

* added multiple simulate handling

* remove commented stop

* lint

* made BatchObservation handler use a continuation to guarantee it's applied after all solves

* lint

* add dynamical intro notebook to CI build

* add CI test parameters

* add a bunch of textual content

* Added description of example

* fixed bug in inference and added some plot changes

* fixed bug in inference and added some plot changes

* updated plots

* updated plots

* more plot updates

* more plot updates

* finished first pass of text, will edit tomorrow morning

* reran and minor edits

* text edits

* add glossary

* Update solver.py

missed merge conflict

* previous commit fix

* add dynamical systems dependencies to CI workflow

* addressing comments

* reran notebook

* Mention dynamical systems module in README (#435)

* Make State into a type alias of Mapping (#433)

* Make State a Mapping

* fix construction

* add dynamical to test requirements (#434)

* Fix header formatting in dynamical_intro (#436)

* Fix header formatting in dynamical_intro

* fix bullet spacing

---------

Co-authored-by: Sam Witty <[email protected]>

---------

Co-authored-by: Sam Witty <[email protected]>
Co-authored-by: eb8680 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation status:awaiting review Awaiting response from reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants