Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Filter Github Issues by label #319

Closed
1 task done
Bashamega opened this issue Sep 18, 2024 · 11 comments
Closed
1 task done

[FEATURE] Filter Github Issues by label #319

Bashamega opened this issue Sep 18, 2024 · 11 comments
Assignees
Labels

Comments

@Bashamega
Copy link
Owner

Is this a unique feature?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.

Hello:)
We should enable the user to filter GitHub Issues by label.

Proposed Solution

When the user clicks on a label it should filter the content.

Screenshots

No response

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this (issue will not be assigned if this is skipped)

No response

Copy link
Contributor

Hello! 👋 Thanks for opening this issue. We appreciate your feedback and will look into it as soon as possible. Feel free to add more details if necessary.

@devendra0009
Copy link
Contributor

devendra0009 commented Sep 18, 2024

hi @Bashamega , i think github label filter is working . Can you record a video and post the specific issue?

@Bashamega
Copy link
Owner Author

hi @Bashamega , i think github label filter is working . Can you record a video and post the specific issue?

When you click on a label nothing happens

@devendra0009
Copy link
Contributor

image

is this the label you are referring to ? If so it is working ok and filtering the github issues

@Bashamega
Copy link
Owner Author

I mean add the option to filter be clicking on the label on the issue.

@dax4y
Copy link
Contributor

dax4y commented Oct 1, 2024

Hello,
my name is Dominik. I am a student of Technical University in Kosice and software developer in NESS Košice.

As part of our course in school is to help some project with issue on GitHub, I would be happy if I could work on this issue, if it is sill relevant ?
Thanks for the answer.

@Bashamega
Copy link
Owner Author

Hello,
my name is Dominik. I am a student of Technical University in Kosice and software developer in NESS Košice.

As part of our course in school is to help some project with issue on GitHub, I would be happy if I could work on this issue, if it is sill relevant ?
Thanks for the answer.

Hello :)
Sure, you can, work on it

@dax4y
Copy link
Contributor

dax4y commented Oct 2, 2024

Hey,
I have a couple of suggestions and ideas how to improve this search:

  1. It would be nice to have options for entering additional label values in filter, not just defaults (e.g. I would like to search GitHub tags by Java so I will add it by some input in "Filter-Modal" component and it will appear in the filter with checkbox)
  2. I think, that it would be more consistent and clearer, when that colored labels (which can be added by filter or now by clicking on them) will appears somewhere on the top in exact same color (now I need to all the time open FILTER by clicking and check which labels are selected)
  3. Also additional reverse functionality which by clicking on the label will delete this label from filter
  4. This one is more complex but maybe nice to have. I will save [label.id]'s in the URL address so when someone will refresh page, selected labels in filter won't be lost

I hope all of this makes sense and let me know what do you guys think.
Thanks.
D.

@Bashamega
Copy link
Owner Author

Hey,
I have a couple of suggestions and ideas how to improve this search:

  1. It would be nice to have options for entering additional label values in filter, not just defaults (e.g. I would like to search GitHub tags by Java so I will add it by some input in "Filter-Modal" component and it will appear in the filter with checkbox)
  2. I think, that it would be more consistent and clearer, when that colored labels (which can be added by filter or now by clicking on them) will appears somewhere on the top in exact same color (now I need to all the time open FILTER by clicking and check which labels are selected)
  3. Also additional reverse functionality which by clicking on the label will delete this label from filter
  4. This one is more complex but maybe nice to have. I will save [label.id]'s in the URL address so when someone will refresh page, selected labels in filter won't be lost

I hope all of this makes sense and let me know what do you guys think.
Thanks.
D.

Sure. You can create prs for it

@dax4y
Copy link
Contributor

dax4y commented Oct 6, 2024

Hey,
I would like to ask you, if I can add some test coverage for this implementation ? I think it would only help :)

Thanks.
D.

@Bashamega
Copy link
Owner Author

Hey, I would like to ask you, if I can add some test coverage for this implementation ? I think it would only help :)

Thanks. D.

Sure

dax4y added a commit to dax4y/WebDevTools that referenced this issue Oct 9, 2024
…abel, the possibility of adding new label in filter
dax4y added a commit to dax4y/WebDevTools that referenced this issue Oct 9, 2024
Bashamega pushed a commit that referenced this issue Oct 10, 2024
* feature #319: implemented filter option by clicking on the label, the possibility of adding new label in filter

* feature #319: implemented filtered labels resistance from refreshing page

* implemented test for GhFinder components

* added remove svg for selected labels

* selected label which is not in filter-list is added automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants