Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme/pete: shellcheck && shfmt #2035

Merged
merged 1 commit into from
Jan 24, 2022
Merged

theme/pete: shellcheck && shfmt #2035

merged 1 commit into from
Jan 24, 2022

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Jan 12, 2022 •
edited
Loading

Description

Simplify Pete's prompt_setter() a little. It's more verbose, but it's clearer what's what.

Motivation and Context

Simplicity, clarity, and #1696.

How Has This Been Tested?

bash-it preview pete

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard marked this pull request as ready for review January 12, 2022 21:35
@NoahGorny NoahGorny merged commit dbb3ea4 into Bash-it:master Jan 24, 2022
@gaelicWizard gaelicWizard deleted the theme/pete branch January 25, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaelicWizard @NoahGorny