Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving specific things away .bash_profile #20

Closed
noqqe opened this issue Nov 4, 2010 · 3 comments
Closed

moving specific things away .bash_profile #20

noqqe opened this issue Nov 4, 2010 · 3 comments

Comments

@noqqe
Copy link
Contributor

noqqe commented Nov 4, 2010

Hi,

since i use bash-it i wonder why all these specific things are placed in bash_profile
i'm talking about:

     export JEKYLL_LOCAL_ROOT="$HOME/Sites/jekyllsite"
     export JEKYLL_REMOTE_ROOT="user@server:/path/to/jekyll/root"
     [...]

and other nginx git_host or rvm stuff. I think you know what i mean. Wouldn't it be better (and maybe more user friendly) if such things are separately placed in lib/jekyll.bash oder in plugins/jekyll.plugin.bash ?

When a new user downloads bash-it, he will see plugins or lib files and remove the ones he doesn't need. thats all. otherwise he got to edit .bash_profile and things as well. this were at least my first steps with bash-it

i think .bash_profile should contain only the basic and general things which are required to use the framework.

just my 2 cents ;)

@ghost
Copy link

ghost commented Nov 4, 2010

My first steps were different, I went to editing my .bash_profile straightaway. And I think that others might rather it be consolidated into one file rather than have to go through multiple files just to find what they need.

@revans
Copy link
Member

revans commented Nov 4, 2010

The point of the config (bash_profile) is so each person can setup these global vars to suit their systems needs. If one isn't using them or has a different location/name it's easy enough to change it in 1 file. (remove, edit, comment out, etc)

Also, if people want to contribute back (which was my hope from the beginning) I wouldn't want them sending pull requests where they had removed a bunch of files from the project itself.

@noqqe
Copy link
Contributor Author

noqqe commented Nov 4, 2010

okay, i haven't thought about this point of configuration yet.
sounds useful too.

cornfeedhobo added a commit to cornfeedhobo/bash-it that referenced this issue Feb 5, 2021
…55fdb9f

55fdb9f Merge pull request Bash-it#24 from bvberkum/pr-21
b360ca5 Use command name, not last argument as shell-name [Bash-it#23]
5c458c9 22 - Document revise behavior with GUI editors
7de4304 Update LICENSE copyright
f784e3a Merge pull request Bash-it#20 from akatrevorjay/pr/zsh-plugin
1901dbe Merge pull request Bash-it#19 from DrVanScott/master
6bcbc7b Add zsh-style plugin for easy load
37bccee fix _typeset_functions_about for functions starting with a dash
27623a9 fix zsh specific issues
2efc446 glossary: list only functions containing 'about'
7899d11 glossary: call _typeset_functions only once
072856e shell(): Fix for cygwin environment
2dc31de avoid error message if gprintf does not exist

git-subtree-dir: vendor/github.com/erichs/composure
git-subtree-split: 55fdb9fa3cd0f181208a46d90da4d87d5b7e4351
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants