cleanup modern theme

Bash-it · Jan 24, 2021 · f50115f · f50115f
1 parent e80e29b
commit f50115f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/clean_files.txt b/clean_files.txt
@@ -39,6 +39,7 @@ themes/barbuk
 themes/atomic
 themes/axin
 themes/base.theme.bash
+themes/modern
 
 # plugins
 #

diff --git a/themes/modern/modern.theme.bash b/themes/modern/modern.theme.bash
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
 SCM_THEME_PROMPT_PREFIX=""
 SCM_THEME_PROMPT_SUFFIX=""
 
@@ -19,14 +21,14 @@ esac
 PS3=">> "
 
 is_vim_shell() {
-	if [ ! -z "$VIMRUNTIME" ]; then
+	if [ -n "$VIMRUNTIME" ]; then
 		echo "[${cyan}vim shell${normal}]"
 	fi
 }
 
 modern_scm_prompt() {
 	CHAR=$(scm_char)
-	if [ $CHAR = $SCM_NONE_CHAR ]; then
+	if [ "$CHAR" = "$SCM_NONE_CHAR" ]; then
 		return
 	else
 		echo "[$(scm_char)][$(scm_prompt_info)]"