Bugfix/delete not cached file #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijn00
approved these changes
Jul 31, 2024
martijn00
force-pushed
the
bugfix/delete-not-cached-file
branch
from
7ac6c91 to
d569cea
Compare
jungho87
reviewed
Sep 28, 2024
| @@ -181,8 +182,9 @@ class CacheStore { | |||
| if (_futureCache.containsKey(cacheObject.key)) { | |||
| _futureCache.remove(cacheObject.key); | |||
| } | |||
| final file = await fileSystem.createFile(cacheObject.relativePath); | |||
| if (await file.exists()) { | |||
| final file = io.File(cacheObject.relativePath); | |||
There was a problem hiding this comment.
@martijn00
Files will not be deleted after this change. Previously, the location of the directory was set within the fileSystem, so can get file information by relativePath. But now, cannot get file information by relativePath because using io.File
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary method createFile
Add Test to check if return null if file is not cached
Move const values to the setup