Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/delete not cached file #387

Merged

Conversation

mateussiqueira
Copy link
Contributor

Remove unnecessary method createFile
Add Test to check if return null if file is not cached
Move const values to the setup

@martijn00 martijn00 force-pushed the bugfix/delete-not-cached-file branch from 7ac6c91 to d569cea Compare July 31, 2024 19:44
@martijn00 martijn00 merged commit 08e671d into Baseflow:develop Jul 31, 2024
9 checks passed
@@ -181,8 +182,9 @@ class CacheStore {
if (_futureCache.containsKey(cacheObject.key)) {
_futureCache.remove(cacheObject.key);
}
final file = await fileSystem.createFile(cacheObject.relativePath);
if (await file.exists()) {
final file = io.File(cacheObject.relativePath);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martijn00
Files will not be deleted after this change. Previously, the location of the directory was set within the fileSystem, so can get file information by relativePath. But now, cannot get file information by relativePath because using io.File

@martijn00 martijn00 mentioned this pull request Oct 9, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants