Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support m4a file extension #358

Merged
merged 4 commits into from
Dec 30, 2021
Merged

support m4a file extension #358

merged 4 commits into from
Dec 30, 2021

Conversation

VICrazy
Copy link
Contributor

@VICrazy VICrazy commented Dec 29, 2021

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

feature

⤵️ What is the current behavior?

The m4a audio file extension is not supported now.

🆕 What is the new behavior (if this is a feature change)?

The m4a audio file extension are already supported.

💥 Does this PR introduce a breaking change?

no

🐛 Recommendations for testing

Download the m4a audio file via http, and then play the file

📝 Links to relevant issues/docs

https://github.com/Baseflow/flutter_cache_manager/pull/172/files

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #358 (ee9003e) into develop (aca37f6) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #358      +/-   ##
===========================================
- Coverage    75.39%   75.28%   -0.11%     
===========================================
  Files           22       23       +1     
  Lines          691      692       +1     
===========================================
  Hits           521      521              
- Misses         170      171       +1     
Impacted Files Coverage Δ
flutter_cache_manager/lib/src/cache_manager.dart 88.31% <ø> (ø)
.../lib/src/cache_managers/default_cache_manager.dart 0.00% <ø> (ø)
flutter_cache_manager/lib/src/cache_store.dart 92.55% <ø> (ø)
...he_manager/lib/src/compat/file_service_compat.dart 93.33% <ø> (ø)
...utter_cache_manager/lib/src/config/_config_io.dart 12.50% <ø> (ø)
flutter_cache_manager/lib/src/config/config.dart 0.00% <ø> (ø)
...tter_cache_manager/lib/src/web/mime_converter.dart 100.00% <ø> (ø)
flutter_cache_manager/lib/src/web/web_helper.dart 95.65% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca37f6...ee9003e. Read the comment docs.

@renefloor
Copy link
Contributor

Sorry about the analyzer, yours is the first PR since the new Flutter stable. If you want I can create a separate PR to fix the analyzer issues.

@VICrazy
Copy link
Contributor Author

VICrazy commented Dec 30, 2021

Sorry about the analyzer, yours is the first PR since the new Flutter stable. If you want I can create a separate PR to fix the analyzer issues.

Thanks, but I want to try fix it.

@renefloor renefloor merged commit 205387b into Baseflow:develop Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants