Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging options #350

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Improve logging options #350

merged 2 commits into from
Nov 29, 2021

Conversation

renefloor
Copy link
Contributor

@renefloor renefloor commented Nov 28, 2021

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

feature

⤵️ What is the current behavior?

Currently there is no way to determine the detail of the logs. It always shows failed downloads.

🆕 What is the new behavior (if this is a feature change)?

The new logger can decrease or increase the amount of logs.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

Fixes

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #350 (d14bfa3) into develop (101c6a1) will increase coverage by 0.17%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #350      +/-   ##
===========================================
+ Coverage    75.21%   75.39%   +0.17%     
===========================================
  Files           21       22       +1     
  Lines          682      691       +9     
===========================================
+ Hits           513      521       +8     
- Misses         169      170       +1     
Impacted Files Coverage Δ
...cache_info_repositories/cache_info_repository.dart 94.11% <0.00%> (ø)
flutter_cache_manager/lib/src/cache_manager.dart 88.31% <60.00%> (ø)
flutter_cache_manager/lib/src/logger.dart 80.00% <80.00%> (ø)
flutter_cache_manager/lib/src/cache_store.dart 92.55% <100.00%> (+0.16%) ⬆️
flutter_cache_manager/lib/src/web/web_helper.dart 95.65% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 101c6a1...d14bfa3. Read the comment docs.

@renefloor renefloor enabled auto-merge November 29, 2021 18:38
@renefloor renefloor merged commit d124fe0 into develop Nov 29, 2021
@renefloor renefloor deleted the feature/logger branch November 29, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant