-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for services playback per review 2 #6
Fixes for services playback per review 2 #6
Commits on Mar 31, 2024
-
Make service_event_ts_lib as private member again
- Motivation: The shared pointer to the service event type support library shall be a member variable to make sure that library loaded during the liveliness of the instance of this class, since we have a raw pointers to its inner members. Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bc4d118 - Browse repository at this point
Copy the full SHA bc4d118View commit details -
Cleanup in PlayerServiceClient::async_send_request(ser_message)
- Rewrite raw pointers arithmetic. Assumption that size_t represent size of the void* may not necessarily be true on all platforms. - Use shared pointer with custom deleter for deserialized message. - Assumption that we can take first element from bounded sequence by dereferencing raw pointer to the bounded sequence may not be necessarily be true and up to the underlying rmw and transport layer implementation. Use dedicated request_member.get_function(request_sequence_ptr, 0) function instead. - Add sanity checks `for service_event_members_` in PlayerServiceClient constructor. Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5f324c1 - Browse repository at this point
Copy the full SHA 5f324c1View commit details -
Refactoring. Do full deserialization and only once
- Rationale: We can't rely on assumption that we can safely partially deserialize service event to the ServiceEventInfo structure. Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6397df6 - Browse repository at this point
Copy the full SHA 6397df6View commit details
Commits on Apr 9, 2024
-
Specify service request from which introspection message and fix uncr…
…ustify errors Signed-off-by: Barry Xu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 94d418f - Browse repository at this point
Copy the full SHA 94d418fView commit details -
Revert uncrustify changes from previous commit.
- Rationale: We are moving to the new version of the uncrustify in rolling and still haven't done it yet fully for the baseline. The discrepancy in style for other untouched files like logging.hpp shall be addressed in a separate PR. Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 00bff3e - Browse repository at this point
Copy the full SHA 00bff3eView commit details -
Rename service_request_from to the service_requests_source
- Also rename enum class ServiceRequestFrom to the ServiceRequestsSource Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 05a3d1d - Browse repository at this point
Copy the full SHA 05a3d1dView commit details
Commits on Apr 10, 2024
-
Add Player::wait_for_sent_service_requests_to_finish() API
- We need this API to be able to write deterministic and non-flaky tests Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9d98b04 - Browse repository at this point
Copy the full SHA 9d98b04View commit details -
Mitigate potential issues related to the operations reordering on ARM
Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b7116b9 - Browse repository at this point
Copy the full SHA b7116b9View commit details -
Make tests play_service_requests_from_service(client) deterministic
- Get rid of timeout inside tests and use newly added player->wait_for_sent_service_requests_to_finish(service_name) API. Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b87c944 - Browse repository at this point
Copy the full SHA b87c944View commit details -
Misc findings and improvements 1
Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bede854 - Browse repository at this point
Copy the full SHA bede854View commit details -
Rename get_services_clients() to the get_service_clients()
Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c5f6c13 - Browse repository at this point
Copy the full SHA c5f6c13View commit details -
Add a new CLI parameter "--publish-service-requests" for Player
Also added a new option publish_service_requests to the PlayOptions. Note: By default rosbag2 player will publish service events only. Signed-off-by: Barry Xu <[email protected]> Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a623a23 - Browse repository at this point
Copy the full SHA a623a23View commit details -
Fix an issue on filtering topic when prepare publishers
Co-authored-by: Barry Xu <[email protected]> Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 091620c - Browse repository at this point
Copy the full SHA 091620cView commit details -
Cleanup in play_without_publish_service_requests
- Long story short: Make it deterministic and run fast. Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3c19873 - Browse repository at this point
Copy the full SHA 3c19873View commit details
Commits on Apr 11, 2024
-
Wrap code which can throw with try-catch in the publish_message(..)
Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 98c14ef - Browse repository at this point
Copy the full SHA 98c14efView commit details -
Delete some part of the code which became absolute and shall not be used
Signed-off-by: Michael Orlov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f270ac1 - Browse repository at this point
Copy the full SHA f270ac1View commit details -
Signed-off-by: Barry Xu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 974d687 - Browse repository at this point
Copy the full SHA 974d687View commit details