Intentionally show spy pane in full screen mode, but not embed mode (e…

…lastic#13395) (elastic#13415)
Bargs · Aug 9, 2017 · aedab18 · aedab18
1 parent e8d1169
commit aedab18
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable_handler.js b/src/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable_handler.js
@@ -45,7 +45,10 @@ export class VisualizeEmbeddableHandler extends EmbeddableHandler {
 
         visualizeScope.savedObj.vis.listeners.click = this.filterBarClickHandler(container.getAppState());
         visualizeScope.savedObj.vis.listeners.brush = this.brushEvent(container.getAppState());
-        visualizeScope.isFullScreenMode = !chrome.getVisible();
+
+        // The chrome is permanently hidden in "embed mode" in which case we don't want to show the spy pane, since
+        // we deem that situation to be more public facing and want to hide more detailed information.
+        visualizeScope.getShouldShowSpyPane = () => !chrome.getIsChromePermanentlyHidden();
 
         container.registerPanelIndexPattern(panel.panelIndex, visualizeScope.savedObj.vis.indexPattern);
 

diff --git a/src/core_plugins/kibana/public/visualize/embeddable/visualize_template.html b/src/core_plugins/kibana/public/visualize/embeddable/visualize_template.html
@@ -1,5 +1,5 @@
 <visualize
-  show-spy-panel="!isFullScreenMode"
+  show-spy-panel="getShouldShowSpyPane()"
   saved-obj="savedObj"
   app-state="appState"
   ui-state="uiState"

diff --git a/src/ui/public/chrome/api/controls.js b/src/ui/public/chrome/api/controls.js
@@ -17,6 +17,10 @@ export default function (chrome, internals) {
     internals.visible = false;
   };
 
+  chrome.getIsChromePermanentlyHidden = () => {
+    return permanentlyHideChrome;
+  };
+
   /**
    * @param {boolean} display - should the chrome be displayed
    * @return {chrome}