Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events to calibration, and fix some stuff/cleanup #24

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

ronlawrence3
Copy link

@BarbourSmith:

Biggest thing this does is it will allow me to simply copy this calibrationStuff file to the other project and not have to try to merge in the drawing stuff, by just hooking into the new events.

  • add new custom event to document body for calibration.
  • During the calibration functions, sent these events, logging begin and end events (for easy copy/paste)

Also a bunch of cleanup

  • call maslow on startup to go get the calibration values and config. added this to a timeout so page loading is more reliable.
  • sorry for some of the whitespace diffs, my IDE cleans some things up for me
  • removed index.gz.html from git, and made it go to dist/ during build. it always has merge conflicts if its in git, and I figure this is really a build artifact.
  • I added the heartbeat messages to the "verbose" thing so I could stop seeing them in the gcode console by toggling that checkbox.
  • Fixed some startup console errors.

Copy link
Owner

@BarbourSmith BarbourSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! I'm sorry it took me so long to review it! Great work! 👍 👍

@@ -751,8 +751,13 @@ function tabletGetFileList(path) {
}

function tabletInit() {
tabletGetFileList('/')
requestModes()
// put in a timeout to allow things to settle. when they were here at startup ui froze from time to time.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this too I think

@BarbourSmith BarbourSmith merged commit 64e83ed into BarbourSmith:Maslow-Main Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants