Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing error logs to an ILogger instead of Console, adding an event for Unsupported Events #140

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

DrEsteban
Copy link

@DrEsteban DrEsteban commented May 21, 2024

@BarRaider
Copy link
Owner

Multiple small pull requests is probably better than one big one

@DrEsteban
Copy link
Author

DrEsteban commented May 22, 2024

You're not wrong haha. But some of the concerns may cause merge conflicts with each other - e.g. the ILogger and UnsupportedEvent, since they touch lines right next to each other.

Would you like me to split it up as follows?:

  1. ILogger + UnsupportedEvent changes
  2. Other Model changes/fixes

@chapterjason
Copy link

Hey @DrEsteban are you still working on this; or do you need someone else to take over?

@DrEsteban DrEsteban closed this Oct 17, 2024
@DrEsteban DrEsteban reopened this Oct 17, 2024
@DrEsteban DrEsteban changed the title Writing error logs to an ILogger instead of Console, adding an event for Unsupported Events, and other fixes Writing error logs to an ILogger instead of Console, adding an event for Unsupported Events Oct 19, 2024
@DrEsteban
Copy link
Author

@BarRaider @chapterjason Finally got around to splitting this up. Second PR is #143.

Feel free to submit fixes or change requests as desired.

@DrEsteban
Copy link
Author

@BarRaider friendly ping! Any feedback here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants