-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing error logs to an ILogger instead of Console, adding an event for Unsupported Events #140
base: master
Are you sure you want to change the base?
Conversation
Multiple small pull requests is probably better than one big one |
You're not wrong haha. But some of the concerns may cause merge conflicts with each other - e.g. the Would you like me to split it up as follows?:
|
Hey @DrEsteban are you still working on this; or do you need someone else to take over? |
@BarRaider @chapterjason Finally got around to splitting this up. Second PR is #143. Feel free to submit fixes or change requests as desired. |
@BarRaider friendly ping! Any feedback here? |
This contains fixes for the issues described in:
It also contains: