Merge pull request #137 from Baptistemontan/fix_routing

fix routing
Baptistemontan · Sep 21, 2024 · 64920d8 · 64920d8
2 parents 9e13f37 + 6a8cc70
commit 64920d8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -4,9 +4,11 @@ on:
   push:
     branches:
       - master
+      - v0.4
   pull_request:
     branches:
       - master
+      - v0.4
 
 env:
   CARGO_TERM_COLOR: always

diff --git a/leptos_i18n/src/routing.rs b/leptos_i18n/src/routing.rs
@@ -66,10 +66,16 @@ fn get_new_path<L: Locale>(
         path_builder.build()
     });
     location.search.with_untracked(|search| {
-        new_path.push_str(search);
+        if !search.is_empty() {
+            new_path.push('?');
+            new_path.push_str(search);
+        }
     });
     location.hash.with_untracked(|hash| {
-        new_path.push_str(hash);
+        if !hash.is_empty() {
+            new_path.push('#');
+            new_path.push_str(hash);
+        }
     });
     new_path
 }