Detect more trait related errors #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jongardiner
commented
Sep 6, 2024
jongardiner
commented
- Fixes bug with old version where duplicate traits and methods could be inserted into a class.
- Won't import identical abstract methods from a trait, but will let you declare them.
- Throw an error when importing the same method from multiple traits (use aliasing and insteadof to avoid).
- Duplicate properties must be identical type, visibility, and default literal value in order to be imported from a trait.
- Duplicate constants must be identical type, visibility, and default literal value in order to be import from a trait.
- All classes and enums checked for duplicate method names.
- Todo: index phase silently discards errors and tries to continue, but analysis phase emits errors.
… be inserted into a class. - Won't import identical abstract methods from a trait, but will let you declare them. - Throw an error when importing the same method from multiple traits (use aliasing and insteadof to avoid). - Duplicate properties must be identical type, visibility, and default literal value in order to be imported from a trait. - Duplicate constants must be identical type, visibility, and default literal value in order to be import from a trait. - All classes and enums checked for duplicate method names. - Todo: index phase silently discards errors and tries to continue, but analysis phase emits errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.