Pass msg color to subscriptions #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
ghost
commented
Oct 23, 2017
| @@ -458,17 +458,13 @@ def add_formatted_text(text, color = nil) | |||
| text << "\n" | |||
| end | |||
| if text =~ /<G>/ or color == Cosmos::GREEN | |||
| text.gsub!(/<G>/, BLANK) | |||
There was a problem hiding this comment.
I wanted to avoid changing the passed in text. Even though above we call chomp! but that seemed like a special case.
ghost
commented
Oct 23, 2017
| clean_lines = '' | ||
| messages = [] | ||
| lines.each do |line| | ||
| if line =~ /<G>/ |
There was a problem hiding this comment.
This is kind of duplicating the Qt routine but it's log output so ...
1 similar comment
|
👍 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #614