Admin updates #1707
Admin updates #1707
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1707 +/- ##
==========================================
- Coverage 78.24% 78.22% -0.03%
==========================================
Files 235 235
Lines 18151 18188 +37
==========================================
+ Hits 14203 14228 +25
- Misses 3948 3960 +12
Continue to review full report at Codecov.
|
| @@ -18,7 +18,7 @@ | |||
| --> | |||
|
|
|||
| <template> | |||
| <v-dialog persistent v-model="show" width="600"> | |||
| <v-dialog :persistent="!readonly" v-model="show" width="600"> | |||
There was a problem hiding this comment.
When is it readonly? read only plugin?
| </template> | ||
| <span>Delete Interface</span> | ||
| </v-tooltip> | ||
| </v-list-item-icon> |
There was a problem hiding this comment.
Can't remember why you said you removed all the delete buttons / methods?
There was a problem hiding this comment.
Because the plugin.txt captures the config. That is what needs to be changed to remove targets etc.
| show-size | ||
| accept=".gem" | ||
| class="mx-2" | ||
| label="Click to select plugin .gem file(s)" | ||
| label="Click to select plugin .gem file to install" |
There was a problem hiding this comment.
New method requires a single upload at a time? I don't think that's a bad thing, just wondering.
There was a problem hiding this comment.
Yes, it was too complicated with multiple gems and dealing with plugin.txt + variables
|
|
||
| # Extract gem and process plugin.txt to determine what VARIABLEs need to be filled in | ||
| pkg = Gem::Package.new(gem_file_path) | ||
| <<<<<<< HEAD |
| end | ||
| end | ||
|
|
||
| # Called by the PluginsController to create the plugin | ||
| # Because this uses ERB it must be run in a seperate process from the API to | ||
| # prevent corruption and single require problems in the current proces | ||
| def self.install_phase2(name, variables, scope:, gem_file_path: nil, validate_only: false) | ||
| <<<<<<< HEAD |
This adds support for the same gem installed multiple times. It also supports changing plugin.txt at install time.
This paves the way for overall configuration import/export (will be the next ticket)