Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Manager upload / download support #1704

Merged
merged 6 commits into from
Jun 25, 2022
Merged

Conversation

jmthomas
Copy link
Contributor

No description provided.

@jmthomas jmthomas changed the title Rework table manager backend Table Manager upload / download support Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1704 (406d23d) into master (c8295fa) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1704      +/-   ##
==========================================
- Coverage   78.22%   78.19%   -0.03%     
==========================================
  Files         235      236       +1     
  Lines       18144    18193      +49     
==========================================
+ Hits        14193    14226      +33     
- Misses       3951     3967      +16     
Impacted Files Coverage Δ
...b/cosmos/tools/table_manager/table_manager_core.rb 88.46% <0.00%> (-10.00%) ⬇️
config/routes.rb 100.00% <0.00%> (ø)
app/controllers/completed_script_controller.rb 100.00% <0.00%> (ø)
app/models/table.rb 90.98% <0.00%> (ø)
lib/cosmos/tools/table_manager/table_config.rb 93.80% <0.00%> (+0.60%) ⬆️
lib/cosmos/models/plugin_model.rb 95.41% <0.00%> (+3.25%) ⬆️
app/controllers/application_controller.rb 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8295fa...406d23d. Read the comment docs.

// },
// {
// divider: true,
// },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is going on here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want the ability to save a binary file from the local filesystem into Minio. Didn't get it to work and didn't want to mess with it with this ticket.

@jmthomas jmthomas merged commit 228241b into master Jun 25, 2022
@jmthomas jmthomas deleted the table_updown_framework branch June 25, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants