-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table report #1683
Table report #1683
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 77.84% 78.18% +0.34%
==========================================
Files 234 233 -1
Lines 18196 18110 -86
==========================================
- Hits 14164 14160 -4
+ Misses 4032 3950 -82
Continue to review full report at Codecov.
|
stage: test # It can run at the same time as unit-test-job (in parallel). | ||
script: | ||
- rubocop | ||
- ls; ./cosmos-control.sh run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to leave the ls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really but none of the gitlab stuff works right now anyway
|
||
# Authorize and rescue the possible execeptions | ||
# @return [Boolean] true if authorize successful | ||
def authorization(permission) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing playwright tests, otherwise looks good.
Also MetadataController does not inherit from ModelController so it is missing the authorization method. |
No description provided.